This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix overflowing notification buttons #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #3920 Auditors: @luixxiul @jkup Test Plan: 1. Open Brave and trigger a notification e.g. visit https://www.browserleaks.com/geo 2. Horizontally resize window so the notification text overflows 3. Confirm that the buttons don't overflow out of the notification
|
Code LGTM! The only thought is it might be better to keep the order the same but just make sure the buttons extend the yellow notification background? My thinking is just that since the message is top left I expect it to be above the top right content on collapse. |
|
@jkup I agree that'd be good, but I can't figure out the CSS to make it look like that. :/ Because this fixes an unsightly bug I think it'd be nice to merge as is. |
|
We need
I'm pushing a PR to fix it. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Notification options have float: right. I moved them to precede other content in the DOM, so now the other content flows around it rather than "pushing" it away.
Fix #3920
Auditors: @luixxiul @jkup
Test Plan:
Should now look like:
